Re: Port power off: ACPI _PLD and other ideas

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2012/8/9 5:30, Moore, Robert wrote:
> I have a comment about the existing _PLD support in Linux.
>
> It uses bitfields, and these are known to not be reliable when using them to extract bits from a predefined bit-packed data structure. (different compilers implement bitfields differently, and there are also endian considerations.)
>
> We are working on a patch to remove these bitfield definitions and also create a function that returns a useable struct from _PLD.
OK. So our work should base on your new patchs.
> Bob
>
> > +struct acpi_pld {
> > +	unsigned int revision:7; /* 0 */
> > +	unsigned int ignore_colour:1; /* 7 */
> > +	unsigned int colour:24; /* 8 */


--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html