Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

[Felipe Balbi <balbi@xxxxxx>]

On Wed, Jul 25, 2012 at 12:30:12PM +0000, Gupta, Ajay Kumar wrote:
> Hi,
> > On Wed, Jul 25, 2012 at 12:19:32PM +0000, Gupta, Ajay Kumar wrote:
> > > Hi,
> > > >
> > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
> > > > > diff --git a/drivers/usb/musb/musb_core.c
> > > > > b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644
> > > > > --- a/drivers/usb/musb/musb_core.c
> > > > > +++ b/drivers/usb/musb/musb_core.c
> > > >
> > > > <snip>
> > > >
> > > > > @@ -1889,6 +1921,7 @@ musb_init_controller(struct device *dev, int
> > > > > nIrq,
> > > > void __iomem *ctrl)
> > > > >  	pm_runtime_enable(musb->controller);
> > > > >
> > > > >  	spin_lock_init(&musb->lock);
> > > > > +	musb->id = pdev->id;
> > > >
> > > > I fail to see where this musb->id would be used. Care to clarify ?
> > >
> > > Sure, It is used in musb_init_debugfs(). Please refer 02/11.
> > 
> > Then it's a bit unnecessary right ?
> > 
> > You can change the directory name to dev_name(musb->controller) as that will
> > already have the id appended to it.
> 
> Well, musb->id is used at many more places and it has to be there. Please refer
> 
> 01/11 where all glue layers using it for:
> +       musb_put_id(&pdev->dev, glue->musb->id);

your struct *_glue{}; should be the one holding the ID as it's the one
who requested it. If you request multiple IDs, you hold multiple IDs
(glue->id0, glue->id1, glue->idN) and so on.

-- 
balbi

Attachment: signature.asc
Description: Digital signature