Re: [PATCH 2/2] USB: dwc3-exynos: Add vbus setup function to the exynos dwc3 glue layer

[Sergei Shtylyov <sshtylyov@xxxxxxxxxx>]

Hello.

On 07/06/2012 06:25 PM, Vivek Gautam wrote:

> From: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>

> This patch retrieves and configures the vbus control gpio via
> the device tree. The suspend/resume callbacks will be later
> modified for vbus control.

> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>

> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 8014a1f..4f95bdf 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
[...]
> @@ -31,6 +32,29 @@ struct dwc3_exynos {
>  	struct clk		*clk;
>  };
>  
> +static int dwc3_setup_vbus_gpio(struct platform_device *pdev)
> +{
> +	int err = 0;

   Don't need to initialize this.

> +	int gpio;
> +
> +	if (!pdev->dev.of_node)
> +		return 0;
> +
> +	gpio = of_get_named_gpio(pdev->dev.of_node,
> +				"samsung,vbus-gpio", 0);
> +	if (!gpio_is_valid(gpio))
> +		return 0;
> +
> +	err = gpio_request(gpio, "dwc3_vbus_gpio");

   Use gpio_request_one() instead and you won't need to call gpio_set_value()
afterwards...

> +	if (err) {
> +		dev_err(&pdev->dev, "can't request dwc3 vbus gpio %d", gpio);
> +		return err;
> +	}
> +	gpio_set_value(gpio, 1);
> +
> +	return err;
> +}
> +
>  static u64 dwc3_exynos_dma_mask = DMA_BIT_MASK(32);
>  
>  static int __devinit dwc3_exynos_probe(struct platform_device *pdev)

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html