Re: [PATCH 3/5] usbdevfs: Don't advertise USBDEVFS_CAP_BULK_CONTINUATION on XHCI attached devs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, Jul 03, 2012 at 11:06:30AM -0700, Sarah Sharp wrote:
> On Mon, Jul 02, 2012 at 11:09:26AM +0200, Hans de Goede wrote:
> > As discussed in length on the mailinglist, USBDEVFS_URB_BULK_CONTINUATION
> > does not work as it should when combined with USBDEVFS_URB_SHORT_NOT_OK
> > (which is its intended use) on devices attached to an XHCI controller.
> > 
> > Note that this patch only does not advertise the cap, bulk transfers
> > with USBDEVFS_URB_BULK_CONTINUATION will still be accepted. Returning
> > -EINVAL for them would break existing apps, and in most cases the
> > troublesome scenario wrt USBDEVFS_URB_SHORT_NOT_OK urbs on XHCI controllers
> > will never get hit, so this would break working use cases.
> > 
> > The disadvantage of not returning -EINVAL is that cases were it is causing
> > real trouble may go undetected / the cause of the trouble may be unclear,
> > but this is the best we can do.
> > 
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> 
> Acked-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> 
> Let me know if Greg wants this patch to come through my queue or not.

There shouldn't be much merge issues with it, so I can take it with the
others when they are resent.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux