Re: [PATCH 1/2] staging: usbip: cleanup and fix of vhci_hub_status
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
On 06/13/2012 10:10 AM, Greg KH wrote:
Greg - forgive my ignorance (or incompetence) here, but what did you ask me to fix? You asked me to resubmit because you were confused on earlier submissions. However, I am not sure what you have asked me to fix in the code. Are you asking me to resubmit in the original form - 3 parts? I guess I am the one that is confused now ...Didn't I ask not to use ? and : in a return statement? That's what I was referring to.
Don't think you did, but I'll make the changes and resubmit. Thanks.I am somewhat curious to the reason why you want me to change the return statement though ... A simple grep returned over 400 similar uses of the ternary operator in return statements throughout the whole tree (67 in drivers/staging) - and I don't think anything is mentioned in the style guide.
Note, my implementation is based on xhci_hub_status_data in drivers/usb/host/xhci-hub.c, which has none of the changes you requested.
Again, I will make the changes and resubmit - just wondering what makes this submission different.
Bart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Media] [Video for Linux] [Linux Input] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Free Online Dating] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive] [More Archives]