Re: [PATCH 01/11] fix wrong label in skel_open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Am Mittwoch, 6. Juni 2012, 18:27:02 schrieb stefani@xxxxxxxxxxx:
> From: Stefani Seibold <stefani@xxxxxxxxxxx>

Thank you for putting the effort to even split this up.
It makes it much easier to review.
 
> Signed-off-by: Stefani Seibold <stefani@xxxxxxxxxxx>
> ---
>  drivers/usb/usb-skeleton.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 0616f23..a57f1d2 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -114,7 +114,7 @@ static int skel_open(struct inode *inode, struct file *file)
>  
>  	retval = usb_autopm_get_interface(interface);
>  	if (retval)
> -		goto out_err;
> +		goto exit;

Are you removing io_mutex? If not, the correct fix is a second label
to drop the lock, not changing the label.  

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux