Re: [PATCH 1/4] usb: dwc3: gadget: drop useless code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Jun 06, 2012 at 01:04:00PM +0530, Pratyush Anand wrote:
> On 6/6/2012 12:37 PM, Felipe Balbi wrote:
> >Hi Pratyush,
> >
> >On Wed, Jun 06, 2012 at 10:04:34AM +0300, Felipe Balbi wrote:
> >>We never set CMDIOC bit for Start Transfer
> >>command, so that code will never be used.
> >>
> >>Signed-off-by: Felipe Balbi<balbi@xxxxxx>
> >
> >Just FYI, I tested this series with g_mass_storage and g_zero by
> >removing a cable with a transfer going on and later reconnecting. I
> >didn't see any crashes while doing that.
> >
> >I still got one warning, but that's because I'm running 1.83a which has
> >a bug of missing disconnect IRQs which is triggering, so nevermind that
> >WARN.
> >
> >Let me know how testing goes on your side.
> >
> 
> Its almost working :)
> 
> Only one warning now I see from  dwc3_endpoint_interrupt
> 
> Transfer In-Progress while ep2in not enabled.

That's the one I added on purpose so we could track this case. Do you
think I should just drop it ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux