Re: [PATCH 02/10] usb: gadget: fsl_qe_udc: Remove unneeded condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 04-06-2012 14:35, Ido Shayevitz wrote:

The removed condition is always true,

   Always false, you mean?

since the endpoint descriptor is
set prior to calling the enable endpoint.

Signed-off-by: Ido Shayevitz<idos@xxxxxxxxxxxxxx>
  drivers/usb/gadget/fsl_qe_udc.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c
index 51881f3..b09452d 100644
--- a/drivers/usb/gadget/fsl_qe_udc.c
+++ b/drivers/usb/gadget/fsl_qe_udc.c
@@ -1596,7 +1596,7 @@ static int qe_ep_enable(struct usb_ep *_ep,
  	ep = container_of(_ep, struct qe_ep, ep);

  	/* catch various bogus parameters */
-	if (!_ep || !desc || ep->ep.desc || _ep->name == ep_name[0] ||
+	if (!_ep || !desc || _ep->name == ep_name[0] ||
  			(desc->bDescriptorType != USB_DT_ENDPOINT))
  		return -EINVAL;

WBR, Sergei
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux