Re: [PATCH 10/10] usb: gadget: s3c-hsudc.c: Remove unneeded condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Am Montag 04 Juni 2012, 12:35:28 schrieb Ido Shayevitz:
> The removed condition is always true, since the endpoint descriptor is
> set prior to calling the enable endpoint.
> 
> Signed-off-by: Ido Shayevitz <idos@xxxxxxxxxxxxxx>

Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>

> ---
>  drivers/usb/gadget/s3c-hsudc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsudc.c
> b/drivers/usb/gadget/s3c-hsudc.c index 36c6836..236b271 100644
> --- a/drivers/usb/gadget/s3c-hsudc.c
> +++ b/drivers/usb/gadget/s3c-hsudc.c
> @@ -760,7 +760,7 @@ static int s3c_hsudc_ep_enable(struct usb_ep *_ep,
>  	u32 ecr = 0;
> 
>  	hsep = our_ep(_ep);
> -	if (!_ep || !desc || hsep->ep.desc || _ep->name == ep0name
> +	if (!_ep || !desc || _ep->name == ep0name
> 
>  		|| desc->bDescriptorType != USB_DT_ENDPOINT
>  		|| hsep->bEndpointAddress != desc->bEndpointAddress
>  		|| ep_maxpacket(hsep) < usb_endpoint_maxp(desc))

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux