Re: [PATCH] usb: fix possible oops in serial option driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, 2012-05-23 at 07:12 +0200, Jan Safrata wrote:
> The mutex cannot be used in the option_send_setup() function, because it
> is already held in usb_wwan_dtr_rts() which calls the option_send_setup(),
> so simple check of serial->disconnected flag should be ok there.
> 
That's cool. The patch should document that, as the fact that there
is no race condition in the code introduced by the patch is somewhat
non-obvious.
(I was initially thinking the same thing.)

-- 
-- Matthias Urlichs

Attachment: signature.asc
Description: This is a digitally signed message part


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux