Re: [RFC 06/13] USB: Add support to enable/disable USB3 link states.

[Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>]

On Thu, May 17, 2012 at 10:32:42PM +0800, Andiry Xu wrote:
> On 05/17/2012 05:55 AM, Sarah Sharp wrote:
> > +	sel_values = kmalloc(sizeof *(sel_values), GFP_NOIO);
> > +	if (!sel_values)
> > +		return -ENOMEM;
> > +
> > +	sel_values->u1_sel = u1_sel;
> > +	sel_values->u1_pel = u1_pel;
> > +	sel_values->u2_sel = cpu_to_le16(u2_sel);
> > +	sel_values->u2_pel = cpu_to_le16(u2_pel);
> > +
> > +	return usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> > +			USB_REQ_SET_SEL,
> > +			USB_RECIP_DEVICE,
> > +			0, 0,
> > +			sel_values, sizeof *(sel_values),
> > +			USB_CTRL_SET_TIMEOUT);
> 
> sel_values is allocated but not freed?

Thanks, I'll fix this too.

Sarah
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html