Re: [PATCH 4/4] CI13xxx: Add USB host interrupt notifier

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Thu, 17 May 2012, Richard Zhao wrote:

> > > It's reasonable to assume that other controllers in the future may have
> > > similar needs -- they may even require multiple PHYs to be notified
> > > about connect changes on multiple ports.  I see nothing wrong with
> > > implementing a callback just for this purpose.  Something like:
> > > 
> > > 	void (*phy_connect_change)(unsigned port, int connected);
> > > 
> > > Then in the port loop in ehci_irq(), you could do:
> > > 
> > > 	if (unlikely(ehci->phy_connect_change && (pstatus & PORT_CSC)))
> > > 		(ehci->phy_connect_change)(i, pstatus & PORT_CONNECT);
> > 
> > Ok Alan, I'll add it into the next series of the ci13xxx stuff we'll craft 
> > together with Richard. Thanks for your guidance!
> How about define a interface to let hcd or udc driver to pass message
> to phy driver?

That's essentially what the suggested code above does.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html