Re: [PATCH v1 4/7] usb: chipidea: add imx driver binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, May 16, 2012 at 05:18:47PM +0300, Alexander Shishkin wrote:
> Richard Zhao <richard.zhao@xxxxxxxxxxxxx> writes:
> 
> > On Wed, May 16, 2012 at 02:38:44PM +0300, Alexander Shishkin wrote:
> >> > +	plat_ci = platform_device_alloc("ci_hdrc", (int)res->start);
> >> 
> >> Regarding the instance id here: you probably want to use something more
> >> meaningful than the starting address. I was thinking about stealing id
> >> allocator from Felipe's dwc3 (dwc3_get_device_id()), but decided to
> >> first deal with more important things.
> > hmm... Is dwc3_get_device_id() really meaningful than base address?
> > It just record the sequence number.
> 
> Well, if you indeed have more than one controller, you might want to
> know, for example, which one registered first. Or, one might simply not
> like the look of "/sys/bus/platform/devices/ci_hdrc.-5898240".
ah, it's singed integer. Then I agree dwc3_get_device_id() is a better
and simple way, and we can find the physical device by looking at
ci_hdrc devicie's parent.

Thanks
Richard
> 
> Regards,
> --
> Alex
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux