Re: USB: ci13xxx_udc.c: remove err() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, May 03, 2012 at 10:32:03PM -0400, Paul Gortmaker wrote:
> Hi Greg,
> 
> I believe that commit 0917ba847ac22 "USB: ci13xxx_udc.c: remove err()
> usage" may not be 100% correct.  This driver had its own instance of
> err() in the header file ci13xxx_udc.h -- so while I don't think your
> change will actively break the driver (since both the err() usages were
> similar), it does leave the driver's own err() code/macro orphaned.

You are right, sorry about that.  I've removed the err() macro now,
ideally the warn() and info() macros should be removed as well by
someone in the future to remove this type of confusion.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux