Re: [PATCH v4 13/24] usb: gadget: ci13xxx: don't use "advance" feature when setting address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, 3 May 2012 16:06:27 +0300, Felipe Balbi <balbi@xxxxxx> wrote:
> On Thu, May 03, 2012 at 03:59:01PM +0300, Alexander Shishkin wrote:
> > On Thu, 3 May 2012 15:51:56 +0300, Felipe Balbi <balbi@xxxxxx> wrote:
> > > On Wed, May 02, 2012 at 05:13:42PM +0300, Alexander Shishkin wrote:
> > > > Newer versions of the chipidea controller support the "advance" setting
> > > > of usb address, which means instead of setting it immediately, deferring
> > > > it till the status completion. Unfortunately, older versions of the
> > > > controller don't have this feature, so in order to support those too, we
> > > > simply don't use it. It's about 4 lines of extra code, and isn't in any
> > > > way critical to performance.
> > > 
> > > in fact this is what specification asks:
> > > 
> > > "The device does not change its device address until after the Status
> > > stage of this request is completed successfully."
> > > 
> > > > With this patch, ci13xxx_udc driver works with the chipidea controller in
> > > > kirkwood (feroceon SoC), as found in, for example, sheevaplug.
> > > >
> > > > Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> > > > ---
> > > >  drivers/usb/gadget/ci13xxx_udc.c |   22 ++++++++++++----------
> > > >  drivers/usb/gadget/ci13xxx_udc.h |    1 +
> > > >  2 files changed, 13 insertions(+), 10 deletions(-)
> > > > 
> > > > diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
> > > > index 8802906..1da415f 100644
> > > > --- a/drivers/usb/gadget/ci13xxx_udc.c
> > > > +++ b/drivers/usb/gadget/ci13xxx_udc.c
> > > > @@ -722,14 +722,13 @@ static int hw_test_and_set_setup_guard(struct ci13xxx *udc)
> > > >   * hw_usb_set_address: configures USB address (execute without interruption)
> > > >   * @value: new USB address
> > > >   *
> > > > - * This function returns an error code
> > > > + * This function explicitly sets the address, without the "USBADRA" (advance)
> > > > + * feature, which is not supported by older versions of the controller.
> > > >   */
> > > > -static int hw_usb_set_address(struct ci13xxx *udc, u8 value)
> > > > +static void hw_usb_set_address(struct ci13xxx *udc, u8 value)
> > > 
> > > changing return from int to void isn't part of $SUBJECT.
> > 
> > Do you really think it's worth a separate patch? No problem with me, but
> > I'm already feeling bad for spamming the list.
> 
> indeed.. so please add a note on commit log that you're also changing
> function prototype or something ;-)

Will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux