RE: [PATCH 2/3 v6] arm: omap: am335x: enable phy controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi,

> -----Original Message-----
> From: Balbi, Felipe
> Sent: Monday, April 30, 2012 2:03 PM
> To: Gupta, Ajay Kumar
> Cc: linux-usb@xxxxxxxxxxxxxxx; Balbi, Felipe; tony@xxxxxxxxxxx
> Subject: Re: [PATCH 2/3 v6] arm: omap: am335x: enable phy controls
> 
> Hi,
> 
> On Mon, Mar 12, 2012 at 07:30:23PM +0530, Ajay Kumar Gupta wrote:
> > Switch on the phy for am335x.
> >
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> > ---
> > Updated the uses of cpu_is_xxx based on Tony's comment.
> >
> >  arch/arm/mach-omap2/omap_phy_internal.c |   34
> ++++++++++++++++++++++--------
> >  1 files changed, 25 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_phy_internal.c
> > b/arch/arm/mach-omap2/omap_phy_internal.c
> > index 4c90477..7d7b3a2 100644
> > --- a/arch/arm/mach-omap2/omap_phy_internal.c
> > +++ b/arch/arm/mach-omap2/omap_phy_internal.c
> > @@ -265,8 +265,21 @@ void ti81xx_musb_phy_power(u8 on)  {
> >  	void __iomem *scm_base = NULL;
> >  	u32 usbphycfg;
> > +	static u8 ti816x, ti814x, ti81xx, am33xx, once;
> > +
> > +	if (!once) {
> > +		ti816x = cpu_is_ti816x();
> > +		ti814x = cpu_is_ti814x();
> > +		ti81xx = cpu_is_ti81xx();
> > +		am33xx = cpu_is_am33xx();
> > +		once = 1;
> > +	}
> 
> wow!!! This is so wrong... This whole omap_phy_internal needs to become
> a driver. I'm not taking this patch, sorry. Only the next one, if it
> compiles properly.

I understand you have been asking for a driver for omap_phy_internal but
the same time this patch and above change was based on feedback from you
and Tony.

If you remember, Tony wanted cpu_is_xxx() check to be done once only in
the function and so the change.

Ajay
> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux