Re: [PATCH 2/3 v6] arm: omap: am335x: enable phy controls

[Felipe Balbi <balbi@xxxxxx>]

Hi,

On Mon, Mar 12, 2012 at 07:30:23PM +0530, Ajay Kumar Gupta wrote:
> Switch on the phy for am335x.
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> ---
> Updated the uses of cpu_is_xxx based on Tony's comment.
> 
>  arch/arm/mach-omap2/omap_phy_internal.c |   34 ++++++++++++++++++++++--------
>  1 files changed, 25 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
> index 4c90477..7d7b3a2 100644
> --- a/arch/arm/mach-omap2/omap_phy_internal.c
> +++ b/arch/arm/mach-omap2/omap_phy_internal.c
> @@ -265,8 +265,21 @@ void ti81xx_musb_phy_power(u8 on)
>  {
>  	void __iomem *scm_base = NULL;
>  	u32 usbphycfg;
> +	static u8 ti816x, ti814x, ti81xx, am33xx, once;
> +
> +	if (!once) {
> +		ti816x = cpu_is_ti816x();
> +		ti814x = cpu_is_ti814x();
> +		ti81xx = cpu_is_ti81xx();
> +		am33xx = cpu_is_am33xx();
> +		once = 1;
> +	}

wow!!! This is so wrong... This whole omap_phy_internal needs to become
a driver. I'm not taking this patch, sorry. Only the next one, if it
compiles properly.

-- 
balbi

Attachment: signature.asc
Description: Digital signature