RE: Null pointer deref with stable kernel 3.0.y - powerpc - fsl-mph-dr

[Chen Peter-B29397 <B29397@xxxxxxxxxxxxx>]

> > > > >
> > > > I am sorry to make you trouble. According to your words, this fix
> > > should not
> > > > go 3.x stable tree, as it relates some code which checked in after
> > > 3.0.27.
> > >
> > > So, should I drop it from the 3.0-stable tree then?
> > >
> > I am not sure if only 3.0-stable needs to drop.
> > This commit (d39514c) needs to added after below commit:
> >
> > commit 314b02f503c2c219fde0fcf6f086fda415f8a847
> > Author: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
> > Date:   Fri Jul 8 00:17:27 2011 -0500
> >
> >     powerpc: implement arch_setup_pdev_archdata
> >
> >     We have a long standing issues with platform devices not have a
> valid
> >     dma_mask pointer.  This hasn't been an issue to date as no platform
> >     device has tried to set its dma_mask value to a non-default value.
> >
> >     Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >     Signed-off-by: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
> 
> 
> I still do not understand, sorry.
> 
> Please tell me exactly what patches need to be applied to the 3.0-stable
> tree to fix this, OR, what patch I should revert.
> 
Sorry to make your trouble.
Please revert below patch for 3.0 stable tree

commit e90fc3cb087ce5c5f81e814358222cd6d197b5db
Author: Peter Chen <peter.chen@xxxxxxxxxxxxx>
Date:   Thu Feb 16 09:41:52 2012 +0800

    usb: Fix build error due to dma_mask is not at pdev_archdata at ARM
    
    When build i.mx platform with imx_v6_v7_defconfig, and after adding
    USB Gadget support, it has below build error:
    
    CC      drivers/usb/host/fsl-mph-dr-of.o
    drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
    drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata'
    has no member named 'dma_mask'
    
    It has discussed at: http://www.spinics.net/lists/linux-usb/msg57302.html
    
    For PowerPC, there is dma_mask at struct pdev_archdata, but there is
    no dma_mask at struct pdev_archdata for ARM. The pdev_archdata is
    related to specific platform, it should NOT be accessed by
    cross platform drivers, like USB.
    
    The code for pdev_archdata should be useless, as for PowerPC,
    it has already gotten the value for pdev->dev.dma_mask at function
    arch_setup_pdev_archdata of arch/powerpc/kernel/setup-common.c.
    
    Tested-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx>
    Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
    Cc: stable <stable@xxxxxxxxxxxxxxx>
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>


> thanks,
> 
> greg k-h


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html