Re: [PATCH 08/11] MXS: Add imx-otg driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Dear Sascha Hauer,

> On Tue, Apr 24, 2012 at 06:13:04PM +0200, Lothar Waßmann wrote:
> > Hi,
> > 
> > Sascha Hauer writes:
> > > On Tue, Apr 24, 2012 at 04:48:14PM +0200, Lothar Waßmann wrote:
> > > > Hi,
> > > > 
> > > > Marek Vasut writes:
> > > > > This driver handles claiming of clocks and memory areas. These are
> > > > > later properly delegated to it's child devices, the USB Host
> > > > > (ehci-mxs) and USB Gadget (ci13xxx-mxs).
> > > > > 
> > > > > Signed-off-by: Marek Vasut <marex@xxxxxxx>
> > > > > Cc: Chen Peter-B29397 <B29397@xxxxxxxxxxxxx>
> > > > > Cc: Detlev Zundel <dzu@xxxxxxx>
> > > > > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > > > > Cc: Li Frank-B20596 <B20596@xxxxxxxxxxxxx>
> > > > > Cc: Lin Tony-B19295 <B19295@xxxxxxxxxxxxx>
> > > > > Cc: Linux USB <linux-usb@xxxxxxxxxxxxxxx>
> > > > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > > > Cc: Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
> > > > > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > > > > Cc: Stefano Babic <sbabic@xxxxxxx>
> > > > > Cc: Subodh Nijsure <snijsure@xxxxxxxxxxxx>
> > > > > Cc: Tony Lin <tony.lin@xxxxxxxxxxxxx>
> > > > > Cc: Wolfgang Denk <wd@xxxxxxx>
> > > > > ---
> > > > > 
> > > > >  drivers/usb/otg/Kconfig   |    6 +
> > > > >  drivers/usb/otg/Makefile  |    1 +
> > > > >  drivers/usb/otg/imx-otg.c |  473
> > > > >  +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed,
> > > > >  480 insertions(+)
> > > > >  create mode 100644 drivers/usb/otg/imx-otg.c
> > > > > 
> > > > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
> > > > > index 5c87db0..e7c6325 100644
> > > > > --- a/drivers/usb/otg/Kconfig
> > > > > +++ b/drivers/usb/otg/Kconfig
> > > > > @@ -116,6 +116,12 @@ config FSL_USB2_OTG
> > > > > 
> > > > >  	help
> > > > >  	
> > > > >  	  Enable this to support Freescale USB OTG transceiver.
> > > > > 
> > > > > +config USB_IMX_COMPOSITE
> > > > > +	bool
> > > > > +	help
> > > > > +	  Composite driver that handles clock and memory mapping for
> > > > > +	  i.MX USB host and USB PHY.
> > > > > +
> > > > > 
> > > > >  config USB_MV_OTG
> > > > >  
> > > > >  	tristate "Marvell USB OTG support"
> > > > >  	depends on USB_EHCI_MV && USB_MV_UDC && USB_SUSPEND
> > > > > 
> > > > > diff --git a/drivers/usb/otg/Makefile b/drivers/usb/otg/Makefile
> > > > > index 41aa509..7d2c631 100644
> > > > > --- a/drivers/usb/otg/Makefile
> > > > > +++ b/drivers/usb/otg/Makefile
> > > > > @@ -20,4 +20,5 @@ obj-$(CONFIG_USB_MSM_OTG)	+= msm_otg.o
> > > > > 
> > > > >  obj-$(CONFIG_AB8500_USB)	+= ab8500-usb.o
> > > > >  fsl_usb2_otg-objs		:= fsl_otg.o otg_fsm.o
> > > > >  obj-$(CONFIG_FSL_USB2_OTG)	+= fsl_usb2_otg.o
> > > > > 
> > > > > +obj-$(CONFIG_USB_IMX_COMPOSITE)	+= imx-otg.o
> > > > > 
> > > > >  obj-$(CONFIG_USB_MV_OTG)	+= mv_otg.o
> > > > > 
> > > > > diff --git a/drivers/usb/otg/imx-otg.c b/drivers/usb/otg/imx-otg.c
> > > > > new file mode 100644
> > > > > index 0000000..8440d909
> > > > > --- /dev/null
> > > > > +++ b/drivers/usb/otg/imx-otg.c
> > > > > @@ -0,0 +1,473 @@
> > > > > +/*
> > > > > + * drivers/usb/otg/imx-otg.c
> > > > > + *
> > > > > + * Freescale i.MX USB composite driver.
> > > > > + *
> > > > > + * Copyright (C) 2012 Marek Vasut <marex@xxxxxxx>
> > > > > + * on behalf of DENX Software Engineering GmbH
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > modify + * it under the terms of the GNU General Public License as
> > > > > published by + * the Free Software Foundation; either version 2 of
> > > > > the License, or + * (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139,
> > > > > USA. + */
> > > > > +
> > > > 
> > > > Why do you call this driver imx-otg when it is actually MXS specific?
> > > > How would you call a corresponding driver for the remaining i.MX
> > > > processors?
> > > 
> > > This is the driver for the all i.MX processors.
> > 
> > If it is for all i.MX processors, it shouldn't access MXS specific
> > registers, like:
> > +		writel(wakeup, x->io_priv + HW_USBPHY_CTRL_SET);
> 
> Indeed not. This should be done in the phy driver.

Ok, so now you figured out that all these set_host() set_peripheral() work() 
calls should be back in the phy driver, not in the imx-otg? hm ... so back to 
the V4 of the patchset?

> 
> Sascha

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


B and H Foto and Electronics Corp.

[Linux Media]     [Video for Linux]     [Linux Input]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]     [More Archives]

Add to Google Powered by Linux