Re: [RFC v3 10/11] usb: gadget: ci13xxx: replace home-brewed logging with dev_{err,warn,info}

[Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>]

On Wed, 18 Apr 2012 16:34:25 +0300, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
> 
> On Tue, Apr 17, 2012 at 03:35:27PM +0300, Alexander Shishkin wrote:
> >  #ifdef TRACE
> > -#define trace(format, args...)      ci13xxx_printk(KERN_DEBUG, format, ## args)
> > -#define dbg_trace(format, args...)  dev_dbg(dev, format, ##args)
> > +#define ci13xxx_printk(dev, format, args...)				\
> > +	do {								\
> > +		if (dev == NULL)					\
> > +			pr_debug("[%s] " format "\n", __func__,		\
> > +			       ## args);				\
> > +		else							\
> > +			dev_printk(KERN_DEBUG, dev, "[%s] " format "\n", \
> > +				   __func__, ## args);			\
> > +	} while (0)
> >  #else
> > -#define trace(format, args...)      do {} while (0)
> > -#define dbg_trace(format, args...)  do {} while (0)
> > +#define trace(dev, format, args...)      do {} while (0)
> >  #endif
> 
> unless my eyes are failing me, but it looks that trace is only defined
> when !TRACE, is that right ?

True, thanks! I'll fix this in the next round.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html