Re: [PATCH RESEND] usb: fix wrong ordered Kconfig entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/22/2012 08:19 AM, Julian Wollrath wrote:
With the current tip of the master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (commit
5375871) some configuration entries that should be under 'Device Drivers/USB
support' appear under 'Device Drivers'. This patch fixes that.

Are you at liberty so say which configuration entries are affected?

There was a reason that USB_ARCH_HAS_* was moved outside of USB_SUPPORT.

After explaining what went wrong, can you try coming up with a fix that continues to not have USB_ARCH_HAS_* depend on USB_SUPPORT?

Without knowing that some effort was made to do that, I would be inclined to say:

NACK

Thanks,
David Daney



Signed-off-by: Julian Wollrath<jwollrath@xxxxxx>
---
  drivers/usb/Kconfig |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index e4405e0..556ca51 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -10,6 +10,8 @@ menuconfig USB_SUPPORT
  	  This option adds core support for Universal Serial Bus (USB).
  	  You will also need drivers from the following menu to make use of it.

+if USB_SUPPORT
+
  # many non-PCI SOC chips embed OHCI
  config USB_ARCH_HAS_OHCI
  	boolean
@@ -63,8 +65,6 @@ config USB_ARCH_HAS_XHCI
  	boolean
  	default PCI

-if USB_SUPPORT
-
  config USB_COMMON
  	tristate
  	default y

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux