Re: [PATCH 3/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/18/2014 05:09 PM, Hans de Goede wrote:
> When using a Renesas uPD720231 chipset usb-3 uas to sata bridge with a 120G
> Crucial M500 ssd, model string: Crucial_ CT120M500SSD1, together with a
> the integrated Intel xhci controller on a Haswell laptop:
> 
> 00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC [8086:9c31] (rev 04)
> 
> The following error gets logged to dmesg:
> 
> xhci error: Transfer event TRB DMA ptr not part of current TD
> 
> Treating COMP_STOP the same as COMP_STOP_INVAL when no event_seg gets found
> fixes this.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-ring.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 5542dfe..d9b3286 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -2483,7 +2483,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,
>  		 * last TRB of the previous TD. The command completion handle
>  		 * will take care the rest.
>  		 */
> -		if (!event_seg && trb_comp_code == COMP_STOP_INVAL) {
> +		if (!event_seg && (trb_comp_code == COMP_STOP ||
> +				   trb_comp_code == COMP_STOP_INVAL)) {
>  			ret = 0;
>  			goto cleanup;
>  		}
> 

Looks good, thanks, I'll apply it.

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux