Re: Test patch for OHCI RHSC

[Andrey Borzenkov <arvidjaar@xxxxxxx>]

On Wednesday 03 September 2008, Alan Stern wrote:
> On Wed, 3 Sep 2008, Andrey Borzenkov wrote:
> 
> > Alan.
> > 
> > good news, I do not see any regression with this patch. It still runs
> > (and suspends) as before.
> > 
> > bad news, I probably won't be able to test power saving feature anyway.
> > My chip is blacklisted in host/ohci-pci.c:ohci_pci_quirks[]
> > 
> >         {
> >                 /* Toshiba portege 4000 */
> >                 .vendor         = PCI_VENDOR_ID_AL,
> >                 .device         = 0x5237,
> >                 .subvendor      = PCI_VENDOR_ID_TOSHIBA,
> >                 .subdevice      = 0x0004,
> >                 .driver_data    = (unsigned long) broken_suspend,
> >         },
> > 
> > and I am unable to re-enable wakeup even for test:
> > 
> > {pts/1}% LC_ALL=C cat /sys/bus/usb/devices/usb1/power/wakeup
> > 
> > {pts/1}% LC_ALL=C sudo sh -c 'echo enabled > /sys/bus/usb/devices/usb1/power/wakeup'
> > sh: line 0: echo: write error: Invalid argument
> 
> That's better than nothing.  Thanks for testing.
> 

I disabled quirk and autosuspend feature seems to work. This is USB stats
since boot with no USB device used:

active_duration:1877380
autosuspend:2
connected_duration:2211746
level:auto
wakeup:enabled

I do not know if those values look good; i would probably expect much higher
difference but at least this seems to indicate patch is working, right?

I keep a watch for some time and send patch to remove quirk if nothing
outstanding comes up.

Attachment: signature.asc
Description: This is a digitally signed message part.