Re: Test patch for OHCI RHSC

[Andrey Borzenkov <arvidjaar@xxxxxxx>]

On Tuesday 02 September 2008, Alan Stern wrote:
> Meelis and Andrey:
> 
> Here's a patch for the two of you to test.  If you don't enable 
> CONFIG_PM then it shouldn't make any difference, but if you do then it 
> should allow your OHCI controllers to enter a low-power state when no 
> devices are attached.  Hopefully it will behave properly even when 
> faced with your broken OHCI hardware.
> 


Alan.

good news, I do not see any regression with this patch. It still runs
(and suspends) as before.

bad news, I probably won't be able to test power saving feature anyway.
My chip is blacklisted in host/ohci-pci.c:ohci_pci_quirks[]

        {
                /* Toshiba portege 4000 */
                .vendor         = PCI_VENDOR_ID_AL,
                .device         = 0x5237,
                .subvendor      = PCI_VENDOR_ID_TOSHIBA,
                .subdevice      = 0x0004,
                .driver_data    = (unsigned long) broken_suspend,
        },

and I am unable to re-enable wakeup even for test:

{pts/1}% LC_ALL=C cat /sys/bus/usb/devices/usb1/power/wakeup

{pts/1}% LC_ALL=C sudo sh -c 'echo enabled > /sys/bus/usb/devices/usb1/power/wakeup'
sh: line 0: echo: write error: Invalid argument

Attachment: signature.asc
Description: This is a digitally signed message part.