Re: [PATCH] usb-storage: report underflow with no sense data

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Tue, 2 Sep 2008, Greg KH wrote:

> On Tue, Sep 02, 2008 at 10:12:11AM -0400, Alan Stern wrote:
> > This patch (as1118) addresses a problem with certain USB mass-storage
> > devices.  These devices sometimes return less data than asked for and
> > then provide no sense data to explain the problem.  Currently
> > usb-storage leaves it up to the SCSI layer to decide how this should
> > be handled, and the SCSI layer interprets the lack of sense data to
> > mean that nothing went wrong.  But if we got less data than required
> > then something definitely _did_ go wrong, and we should say so.
> > 
> > The patch tells the SCSI layer to retry the command when this sort of
> > thing happens.  Retrying may not solve the underlying problem, but
> > it's better than believing that data was transferred when it wasn't.
> > 
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> Is this a 2.6.27 or .28 patch?

I don't know for certain that anybody currently has hardware which 
would be fixed by this patch.  So while it should be okay for 2.6.27, 
delaying it until 2.6.28 won't hurt anything.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html