Re: [patch 2.6.27-rc5] usb gadget: fix omap_udc DMA regression

[Russell King <rmk@xxxxxxxxxxxxxxxx>]

On Sun, Aug 31, 2008 at 06:04:27PM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> 
> This resolves another regression caused by the "use omap_read/write
> instead of __REG" patch:  the hardware address used for DMA to/from
> the UDC became wrong.  Bug noted by Russell King.
> 

Reported-by: Russell King <rmk@xxxxxxxxxxxxxxxx>

> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

Acked-by: Russell King <rmk@xxxxxxxxxxxxxxxx>

Thanks.

> ---
>  drivers/usb/gadget/omap_udc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/usb/gadget/omap_udc.c
> +++ b/drivers/usb/gadget/omap_udc.c
> @@ -787,7 +787,7 @@ static void dma_channel_claim(struct oma
>  			omap_set_dma_dest_params(ep->lch,
>  				OMAP_DMA_PORT_TIPB,
>  				OMAP_DMA_AMODE_CONSTANT,
> -				(unsigned long) io_v2p(UDC_DATA_DMA),
> +				UDC_DATA_DMA,
>  				0, 0);
>  		}
>  	} else {
> @@ -804,7 +804,7 @@ static void dma_channel_claim(struct oma
>  			omap_set_dma_src_params(ep->lch,
>  				OMAP_DMA_PORT_TIPB,
>  				OMAP_DMA_AMODE_CONSTANT,
> -				(unsigned long) io_v2p(UDC_DATA_DMA),
> +				UDC_DATA_DMA,
>  				0, 0);
>  			/* EMIFF or SDRC */
>  			omap_set_dma_dest_burst_mode(ep->lch,

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html