Re: [PATCH][1/2] usb: dma bounce buffer support V3

[David Brownell <david-b@xxxxxxxxxxx>]

On Monday 21 January 2008, Andrew Morton wrote:
> It is unobvious (to me) why this code uses put_unaligned() and
> get_unaligned() in the places where it does.  So I'll assume that it will
> be unobvious to other reviewers and readers.  

It was unobvious to me too.  "Shouldn't be needed" was one
of my as-yet-unsent comments on this round.


> Addition of suitable comments would help here.  Unless this is all
> blindingly obvious to anyone who has a useful knowledge of USB core?

It's all a bit of a hack to _portably_ support controllers that
require their buffers to live in a particular (local) memory
block.  There's some dmabounce code in the ARM stack, but that
won't work for SH and doesn't easily accomodate the "local"
semantics.

And again, one of my as-yet-unsent comments was about this very
issue.  (The comments that are there are a bit sparse and don't
touch on the real issues.)  Very optimistically, this means one
of us can reduce (or at least shift!) our load of code reviews.  ;)

- Dave




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel