Google
  Web www.spinics.net

Re: [PATCH][1/2] usb: dma bounce buffer support V3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, 22 Jan 2008 12:20:10 +0900 Magnus Damm <magnus.damm@xxxxxxxxx> wrote:

> usb: dma bounce buffer support V3
> 
> This patch adds dma bounce buffer support to the usb core. These buffers
> can be enabled with the HCD_LOCAL_MEM flag, and they make sure that all data
> passed to the host controller is allocated using dma_alloc_coherent().

It is unobvious (to me) why this code uses put_unaligned() and
get_unaligned() in the places where it does.  So I'll assume that it will
be unobvious to other reviewers and readers.  

Addition of suitable comments would help here.  Unless this is all
blindingly obvious to anyone who has a useful knowledge of USB core?



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

[Home]     [Video for Linux]     [Photo]     [Yosemite Forum]     [Yosemite Photos]    [Video Projectors]     [PDAs]     [Hacking TiVo]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]     [Free Dating]

  Powered by Linux