Re: [PATCH] Fix clk->enabled counter

[Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>]

David Brownell wrote:

> On Thursday 10 January 2008, Dmitry Baryshkov wrote:
>> Hi,
>> 
>> eric miao wrote:
>> 
>> > isn't it better to extract clk_{enable, disable} from udc_disable()?
>> > this can be treated as two different things, one is for the clock,
>> > the other controls the udc register bit, and better be divided.
>> 
>> Good idea. What about this patch:
> 
> Minor issues as noted below.  You tested this?  With suspend, resume,
> remote wakeup, unplug-while-active, and rmmod g_<what> scenarios to make
> sure the main code paths behave OK?


I've tested with g_ether the suspend/resume of gadget (got log messages
as found bellow, but otherwise OK), plug-unplug also works. Can't test
rmmod/modrobe as I don't build modular kernels for my device.
Also what do you mean by remote wakeup?
I'll try making modules to work, fix things you noted and resubmit the patch.


-- 
With best wishes
Dmitry



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel