Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

[Hans de Goede <j.w.r.degoede@xxxxxx>]

Boaz Harrosh wrote:
> On Thu, Jan 10 2008 at 12:52 +0200, Hans de Goede <j.w.r.degoede@xxxxxx> wrote:
>>> I'm not sure what the proper solution should be?
>>>
>> I guess the proper solution would be to add a special case to the scsi layer 
>> where the read10 / write10 command is issued, and split the request in 2 there 
>> when it involves the last sector.
>>
>> There was another reply in this thread stating that problems reading the last 
>> sector with sd / mmc cards happen quite often, and that this is most likely not 
>> an isolated case.
>>
>> Regards,
>>
>> Hans
> 
> Yes, you're right. in ULDs it is a much proper way to do this.
> 
> So I guess you'll have to do that special host flag or device
> flag, and add a check for it in sd.c. You'll see that sd.c is 
> already doing bufflen truncation at sd_prep_fn(), just add one
> more case.
> 

Yes,

That will work nicely, I'll write an updated patch this evening (when I have 
access to the printer to test again).

Regards,

Hans



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel