Re: [Bugme-new] [Bug 9573] New: NULL pointer dereference on drivers/usb/serial/whiteheat.c

[Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>]

On Thu, 20 Dec 2007 12:23:03 +0100
Oliver Neukum <oliver@xxxxxxxxxx> wrote:

> Am Sonntag, 16. Dezember 2007 05:23:47 schrieb Andrew Morton:
> > On Sat, 15 Dec 2007 07:08:52 -0800 (PST) bugme-daemon@xxxxxxxxxxxxxxxxxxx wrote:
> > 
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9573
>  
> > > There's a null pointer dereference on drivers/usb/serial/whiteheat.c as
> > > follows:
> > > 
> > > (1) line 613:  the test "if (port->tty)" implies that null is a legal value
> > >     for "port->tty" at that point
> > > 
> > > (2) neither firm_open nor firm_purge initialize "port->tty"
> 
> drivers/usb/serial/usb-serial::serial_open() sets port->tty
> The check for NULL is bogus. This patch removes the check.
> 
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>

USB serial is full of these. Happy hunting

Acked-by: Alan Cox <alan@xxxxxxxxxx>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel