Re: [Bugme-new] [Bug 9569] New: NULL pointer dereference on drivers/usb/host/ehci-q.c

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Sat, 15 Dec 2007, David Brownell wrote:

> > Does changing the "||" in line 740 to "&&" fix the problem?  It 
> > certainly seems that the test should use an "and" rather than an "or".
> 
> No; when there's an external root hub, that field needs to be set.

"External root hub"?  I'm confused.

> > It also seems that the first part of the test should be urb->dev->tt !=
> > NULL rather than !ehci_is_TDI(ehci).  After all, in the future there
> > might be sorts of controllers other than TDI's with built-in root-hub
> > TTs.
> 
> Unless they patented that obvious feature. :)

Patents expire.  Unlike copyrights, the way things have been going...  :-(

Alan Stern


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel