Re: [Bugme-new] [Bug 9569] New: NULL pointer dereference on drivers/usb/host/ehci-q.c

[David Brownell <david-b@xxxxxxxxxxx>]

> http://bugzilla.kernel.org/show_bug.cgi?id=9569

> (4) the first disjunct at the "if" statement on line 731 evaluates to true

	if (ehci_has_fsl_portno_bug(ehci))

Note that implicitly, when that's true this is an ARC/TDI based
core (with root hub TT support).


> (5) the statement at line 742 executes with urb->dev->tt  NULL.

	/* set the address of the TT; for TDI's integrated
	 * root hub tt, leave it zeroed.
	 */
	if (!ehci_is_TDI(ehci)
			|| urb->dev->tt->hub !=
				ehci_to_hcd(ehci)->self.root_hub)
		info2 |= urb->dev->tt->hub->devnum << 16;

It looks like this is an ARC-derived core, and no root hub TT has been set up.  Moreover, it looks like even the original patch adding
root hub TT support (only for the PCI based devboard/FPGA) didn't
actually set up such a TT ... so this bug has been around for a very
long time.

I put a proposed patch into bugzilla (which I took OFF the CC list).

- Dave


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel