Re: [Bugme-new] [Bug 9569] New: NULL pointer dereference on drivers/usb/host/ehci-q.c

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Fri, 14 Dec 2007, Andrew Morton wrote:

> On Fri, 14 Dec 2007 19:24:38 -0800 (PST) bugme-daemon@xxxxxxxxxxxxxxxxxxx wrote:
> 
> > http://bugzilla.kernel.org/show_bug.cgi?id=9569
> > 
> >            Summary: NULL pointer dereference on drivers/usb/host/ehci-q.c

> > There is a NULL pointer dereference at drivers/usb/host/ehci-q.c, line 742.
> > The pointer that is null at that line is urb->dev->tt. The reason for the
> > error is as follows:

Does changing the "||" in line 740 to "&&" fix the problem?  It 
certainly seems that the test should use an "and" rather than an "or".

It also seems that the first part of the test should be urb->dev->tt !=
NULL rather than !ehci_is_TDI(ehci).  After all, in the future there
might be sorts of controllers other than TDI's with built-in root-hub
TTs.

Alan Stern


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel