Re: [RFC PATCH 1/1] USB: FEATURE_REMOVAL: USB driver API moves to EXPORT_SYMBOL_GPL

[Greg KH <gregkh@xxxxxxx>]

On Thu, Dec 06, 2007 at 01:15:09AM +0200, Felipe Balbi wrote:
> Following what is mentioned in feature-removal-schedule.txt this
> moves the two missing pieces in drivers/usb/core/driver.c to
> EXPORT_SYMBOL_GPL.
> 
> Non-gpl code should be done in userspace using usbfs | libusb | gadgetfs
> instead of trying to hook up binary-only drivers to the kernel.
> 
> Signed-off-by: Felipe Balbi <felipe.lima@xxxxxxxxxxx>
> ---
>  Documentation/feature-removal-schedule.txt |   16 ----------------
>  drivers/usb/core/driver.c                  |    4 ++--
>  2 files changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index 20c4c8b..105dbc0 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -156,22 +156,6 @@ Who:	Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
>  
>  ---------------------------
>  
> -What:	USB driver API moves to EXPORT_SYMBOL_GPL
> -When:	February 2008

But it is not February 2008 yet.  Why would you send this kind of patch
ahead of the declared time frame?

Also, this is not how the patch should be done, the
EXPORT_SYMBOL_GPL_FUTURE() symbols will just be changed to
EXPORT_SYMBOL_GPL(), that's all that is needed.

> -EXPORT_SYMBOL(usb_driver_claim_interface);
> +EXPORT_SYMBOL_GPL(usb_driver_claim_interface);

Not many of the USB drivers actually use this function, so changing the
marking on it will not even achieve what you are trying to do.

Totally confused,

greg k-h

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel