Re: PXA27x UDC Power

[Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>]

On Thu, 29 Nov 2007, Justin Clacherty wrote:

> Justin Clacherty wrote:
> > Given that it won't likely change over the lifetime of the product is it 
> > better to implement this as a compile time kernel configuration option 
> > rather than a command line option?
> >   
> How's this?
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index d80b1e4..68f150e 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -468,6 +468,17 @@ config USB_ETH_RNDIS
>         XP, you'll need to download drivers from Microsoft's website; a URL
>         is given in comments found in that info file.
>  
> +config USB_ETH_HIGH_POWER
> +    bool "High power device support"
> +    depends on USB_ETH
> +    default n

You might want to generalize this.  There's nothing special about the 
Ethernet gadget; other sorts might need high power too.

And there's no reason to make it a boolean.  You might as well have
people specify the actual maximum mA value here, so that the drivers
can incorporate the number (divided by 2!) directly into their
descriptors.

Alan Stern


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel