Re: [PATCH] Fix signr comment in usbdevice_fs.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Stern wrote:
> Good except for the fact that signr is 0 to indicate no signal should 
> be sent.  I guess that's another error in the comment.  How can an 
> unsigned int be equal to -1 anyway?

Ha!  Someone was having a bad day when they added that comment!


This trivial documentation patch corrects a comment in usbdevice_fs.h; it
previously suggested that the signal would only be sent on error, but I am
told that it is sent on both successful and unsuccessful completion, and
that zero indicates that no signal should be sent.

Signed-off-by: "Phil Endecott" <spam_from_usb_devel@xxxxxxxxxxxx>

--- linux/include/linux/usbdevice_fs.h.orig	2007-10-29 
19:28:56.000000000 +0000
+++ linux/include/linux/usbdevice_fs.h	2007-10-29 19:33:27.000000000 +0000
@@ -102,7 +102,8 @@ struct usbdevfs_urb {
  	int start_frame;
  	int number_of_packets;
  	int error_count;
-	unsigned int signr;  /* signal to be sent on error, -1 if none should 
be sent */
+	unsigned int signr;	/* signal to be sent on completion,
+				   or 0 if none should be sent. */






-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

[Index of Archives]     [Video for Linux]     [Photo]     [Yosemite Forum]     [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]

  Powered by Linux