Re: [PATCH 2/3] USB: r8a66597-hcd: fix driver removing

[Yoshihiro Shimoda <shimoda.yoshihiro@xxxxxxxxxxx>]

Alan Stern wrote:
>> diff -uprN a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
>> --- a/drivers/usb/host/r8a66597-hcd.c	2007-10-04 10:34:58.000000000 +0900
>> +++ b/drivers/usb/host/r8a66597-hcd.c	2007-10-04 10:40:20.000000000 +0900
>> @@ -2126,8 +2126,8 @@ static int __init_or_module r8a66597_rem
>>  	struct usb_hcd		*hcd = r8a66597_to_hcd(r8a66597);
>>
>>  	del_timer_sync(&r8a66597->rh_timer);
>> -	iounmap((void *)r8a66597->reg);
>>  	usb_remove_hcd(hcd);
>> +	iounmap((void *)r8a66597->reg);
>>  	usb_put_hcd(hcd);
>>  	return 0;
>>  }
>
> This is right.  This is how the other HCDs work; they release resources
> and I/O mappings between the calls to usb_remove_hcd and usb_put_hcd.

Thank you very much for your comment.
I should have seen other HCDs beforehand.

I will submit this patch.

Thanks,
Yoshihiro Shimoda


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel