- Subject: Re: [PATCH 1/2] PERF(kernel): Cleanup power events
- From: Frederic Weisbecker <fweisbec@xxxxxxxxx>
- Date: Fri, 1 Oct 2010 17:58:25 +0200
- Cc: Thomas Renninger <trenn@xxxxxxx>, linux-trace-users@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, mingo@xxxxxxx, rjw@xxxxxxx, jean.pihet@xxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Frank Eigler <fche@xxxxxxxxxx>
- In-reply-to: <4CA60385.6040405@xxxxxxxxxxxxxxx>
- References: <1285945464-10884-1-git-send-email-trenn@xxxxxxx> <1285945464-10884-2-git-send-email-trenn@xxxxxxx> <4CA60385.6040405@xxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 01, 2010 at 08:51:33AM -0700, Arjan van de Ven wrote:
> On 10/1/2010 8:04 AM, Thomas Renninger wrote:
>> New power trace events:
>> power:processor_idle
>> power:processor_frequency
>> power:machine_suspend
>>
>>
>> C-state/idle accounting events:
>> power:power_start
>> power:power_end
>> are replaced with:
>> power:processor_idle
>>
>> and
>> power:power_frequency
>> is replaced with:
>> power:processor_frequency
>>
>> power:machine_suspend
>> is newly introduced, a first implementation
>> comes from the ARM side, but it's easy to add these events
>> in X86 as well if needed.
>>
>> the type= field got removed from both, it was never
>> used and the type is differed by the event type itself.
>>
>> perf timechart
>> userspace tool gets adjusted in a separate patch.
>>
>> Signed-off-by: Thomas Renninger<trenn@xxxxxxx>
>> CC: Jean Pihet<jean.pihet@xxxxxxxxxxxxxx>
>> CC: Arjan van de Ven<arjan@xxxxxxxxxxxxxxx>
>
>
> As before, strong NACK from me before, this is an ABI break.
Yeah. I wish we can keep power_start and power_end events,
at least for some time.
I know this is very ugly, but this is the only solution if
we want to conciliate forward progress and backward
compatibility.
--
To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Development]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]