- Subject: Re: [PATCH] tracing, perf: add more power related events
- From: Jean Pihet <jean.pihet@xxxxxxxxxxxxxx>
- Date: Wed, 22 Sep 2010 17:36:04 +0200
- Cc: Thomas Renninger <trenn@xxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, arjan@xxxxxxxxxxxxx, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, discuss@xxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, linux-trace-users@xxxxxxxxxxxxxxx
- In-reply-to: <4C9A21AD.1000800@xxxxxxxxxxxxxxx>
- References: <AANLkTinUmbSUUuxUzc8++pcb9gd1CZFdyTQFrveTBXyV@xxxxxxxxxxxxxx> <201009171736.14170.trenn@xxxxxxx> <20100917162412.GB3341@xxxxxxx> <201009180026.59482.trenn@xxxxxxx> <AANLkTimMAr9kEzybFGai3qGyXx36v055iPpXq_C1vW8C@xxxxxxxxxxxxxx> <4C9A21AD.1000800@xxxxxxxxxxxxxxx>
On Wed, Sep 22, 2010 at 5:33 PM, Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:
> On 9/22/2010 8:31 AM, Jean Pihet wrote:
>>
>> Hi,
>>
>> Here is a patch that redefines the power events API. The advantages
>> are: easier maintainance of the kernel and the
>> user space tools, a cleaner and more generic interface, more
>> parameters for fine tracing and even documentation!
>>
>> Thomas, this patch has your patch above merged in ('power-trace: Use
>> power_switch_state instead of power_start and power_end'). The revised
>> ACPI patch is coming asap.
>>
>> The trace points for x86 and OMAP are also udated accordingly.
>>
>> The pytimechart tool needs an update for the new API. This can be done
>> as soon as the kernel code gets merged in.
>
> unfortunately this code is changing a userspace ABI... we really shouldn't
> do that if we can avoid it,
> and here we can avoid it.
>
> applications ARE using this stuff!
What are the apps that are using it? I know about builtin-timechart,
pytimechart. Is powertop using this as well?
Is it better to go for a 3 steps approach (add new API, change tools,
deprecate old API) like proposed above?
Thanks,
Jean
--
To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Development]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]