- Subject: [tip:perf/core] perf hists: Print newline between hists callchains
- From: tip-bot for Frederic Weisbecker <fweisbec@xxxxxxxxx>
- Date: Wed, 25 Jul 2012 12:23:36 -0700
- Cc: acme@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, mingo@xxxxxxxxxx, a.p.zijlstra@xxxxxxxxx, namhyung@xxxxxxxxx, jolsa@xxxxxxxxxx, fweisbec@xxxxxxxxx, dsahern@xxxxxxxxx, tglx@xxxxxxxxxxxxx
- Git-commit-id: 6654f5d8bdaa438b1e60dfeb90f9d46ca969c012
- In-reply-to: <1342631456-7233-3-git-send-email-fweisbec@gmail.com>
- Reply-to: mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, acme@xxxxxxxxxx, fweisbec@xxxxxxxxx, a.p.zijlstra@xxxxxxxxx, dsahern@xxxxxxxxx, tglx@xxxxxxxxxxxxx, namhyung@xxxxxxxxx, jolsa@xxxxxxxxxx
- Robot-id: <tip-bot.git.kernel.org>
- Robot-unsubscribe: Contact <mailto:hpa@xxxxxxxxxx> to get blacklisted from these emails
Commit-ID: 6654f5d8bdaa438b1e60dfeb90f9d46ca969c012
Gitweb: http://git.kernel.org/tip/6654f5d8bdaa438b1e60dfeb90f9d46ca969c012
Author: Frederic Weisbecker <fweisbec@xxxxxxxxx>
AuthorDate: Wed, 18 Jul 2012 19:10:56 +0200
Committer: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
CommitDate: Wed, 25 Jul 2012 11:32:26 -0300
perf hists: Print newline between hists callchains
Tiny cosmetic fix. The lack of a newline between hists callchains was
looking slightly messy.
Before:
0.24% swapper [kernel.kallsyms] [k] _raw_spin_lock_irq
|
--- _raw_spin_lock_irq
run_timer_softirq
__do_softirq
call_softirq
do_softirq
irq_exit
smp_apic_timer_interrupt
apic_timer_interrupt
default_idle
amd_e400_idle
cpu_idle
start_secondary
0.10% perf [kernel.kallsyms] [k] lock_is_held
|
--- lock_is_held
__might_sleep
mutex_lock_nested
perf_event_for_each_child
perf_ioctl
do_vfs_ioctl
sys_ioctl
system_call_fastpath
ioctl
cmd_record
run_builtin
main
__libc_start_main
After:
0.24% swapper [kernel.kallsyms] [k] _raw_spin_lock_irq
|
--- _raw_spin_lock_irq
run_timer_softirq
__do_softirq
call_softirq
do_softirq
irq_exit
smp_apic_timer_interrupt
apic_timer_interrupt
default_idle
amd_e400_idle
cpu_idle
start_secondary
0.10% perf [kernel.kallsyms] [k] lock_is_held
|
--- lock_is_held
__might_sleep
mutex_lock_nested
perf_event_for_each_child
perf_ioctl
do_vfs_ioctl
sys_ioctl
system_call_fastpath
ioctl
cmd_record
run_builtin
main
__libc_start_main
Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Link: http://lkml.kernel.org/r/1342631456-7233-3-git-send-email-fweisbec@xxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/util/hist.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 90dc35a..f247ef2 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -749,6 +749,8 @@ static size_t callchain__fprintf_graph(FILE *fp, struct rb_root *root,
ret += __callchain__fprintf_graph(fp, root, total_samples,
1, 1, left_margin);
+ ret += fprintf(fp, "\n");
+
return ret;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Devel]
[Linux Video &Media]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]