- Subject: [tip:perf/core] tracing/selftest: Add a WARN_ON() if a tracer test fails
- From: tip-bot for Steven Rostedt <srostedt@xxxxxxxxxx>
- Date: Fri, 6 Jul 2012 03:47:00 -0700
- Cc: hpa@xxxxxxxxx, mingo@xxxxxxxxxx, rostedt@xxxxxxxxxxx, srostedt@xxxxxxxxxx, tglx@xxxxxxxxxxxxx
- Git-commit-id: 0be61ebc18b919dddbdbcd1c4f42513c310ecf59
- Reply-to: linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, rostedt@xxxxxxxxxxx, srostedt@xxxxxxxxxx, tglx@xxxxxxxxxxxxx
- Robot-id: <tip-bot.git.kernel.org>
- Robot-unsubscribe: Contact <mailto:hpa@xxxxxxxxxx> to get blacklisted from these emails
Commit-ID: 0be61ebc18b919dddbdbcd1c4f42513c310ecf59
Gitweb: http://git.kernel.org/tip/0be61ebc18b919dddbdbcd1c4f42513c310ecf59
Author: Steven Rostedt <srostedt@xxxxxxxxxx>
AuthorDate: Mon, 18 Jun 2012 09:28:16 -0400
Committer: Steven Rostedt <rostedt@xxxxxxxxxxx>
CommitDate: Thu, 28 Jun 2012 13:52:14 -0400
tracing/selftest: Add a WARN_ON() if a tracer test fails
Add a WARN_ON() output on test failures so that they are easier to detect
in automated tests. Although, the WARN_ON() will not print if the test
causes the system to crash, obviously.
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
kernel/trace/trace.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 49249c2..748f640 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -830,6 +830,8 @@ int register_tracer(struct tracer *type)
current_trace = saved_tracer;
if (ret) {
printk(KERN_CONT "FAILED!\n");
+ /* Add the warning after printing 'FAILED' */
+ WARN_ON(1);
goto out;
}
/* Only reset on passing, to avoid touching corrupted buffers */
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Devel]
[Linux Video &Media]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]