Re: [PATCH v4 05/10] ARM: tegra: Provide clock for only one PWM controller |
|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v4 05/10] ARM: tegra: Provide clock for only one PWM controller
- From: Stephen Warren <swarren@xxxxxxxxxxxxx>
- Date: Tue, 20 Mar 2012 09:27:58 -0600
- Cc: devicetree-discuss@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Matthias Kaehlcke <matthias@xxxxxxxxxxxx>, Kurt Van Dijck <kurt.van.dijck@xxxxxx>, Rob Herring <rob.herring@xxxxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxxxx>, Colin Cross <ccross@xxxxxxxxxxx>, Olof Johansson <olof@xxxxxxxxx>, Richard Purdie <rpurdie@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>, Mitch Bradley <wmb@xxxxxxxxxxxxx>, Mike Frysinger <vapier@xxxxxxxxxx>, Eric Miao <eric.y.miao@xxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Ryan Mallon <rmallon@xxxxxxxxx>
- In-reply-to: <20120320084403.GB20249@avionic-0098.adnet.avionic-design.de>
- User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15
On 03/20/2012 02:44 AM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 03/14/2012 09:56 AM, Thierry Reding wrote:
>>> A subsequent patch will add a generic PWM API driver for the Tegra PWFM
>>> controller, supporting all four PWM devices with a single PWM chip. The
>>> device will be named tegra-pwm and only one clock needs to be provided.
>>>
>>> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
>>> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>> ...
>>> - CLK_DUPLICATE("pwm", "tegra_pwm.0", NULL),
>>> - CLK_DUPLICATE("pwm", "tegra_pwm.1", NULL),
>>> - CLK_DUPLICATE("pwm", "tegra_pwm.2", NULL),
>>> - CLK_DUPLICATE("pwm", "tegra_pwm.3", NULL),
>>> + CLK_DUPLICATE("pwm", "tegra-pwm", NULL),
>>
>> I thought harder about this: Why not delete /all/ the CLK_DUPLICATE()s
>> for PWM, and change the second parameter to PERIPH_CLK for PWM from
>> "pwm" to "tegra-pwm"?
>
> I think that should work. I'll retest and will update the patch accordingly.
> I assume that you're Acked-by will remain valid after those changes?
Yes in this case, assuming the patch looks like what I think it will:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[ARM Kernel]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]