Re: [PATCH v4 05/10] ARM: tegra: Provide clock for only one PWM controller |
|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v4 05/10] ARM: tegra: Provide clock for only one PWM controller
- From: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
- Date: Tue, 20 Mar 2012 09:44:03 +0100
- Cc: devicetree-discuss@xxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Matthias Kaehlcke <matthias@xxxxxxxxxxxx>, Kurt Van Dijck <kurt.van.dijck@xxxxxx>, Rob Herring <rob.herring@xxxxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxxxx>, Colin Cross <ccross@xxxxxxxxxxx>, Olof Johansson <olof@xxxxxxxxx>, Richard Purdie <rpurdie@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>, Mitch Bradley <wmb@xxxxxxxxxxxxx>, Mike Frysinger <vapier@xxxxxxxxxx>, Eric Miao <eric.y.miao@xxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Ryan Mallon <rmallon@xxxxxxxxx>
- In-reply-to: <4F67E8E4.7000604@wwwdotorg.org>
- User-agent: Mutt/1.5.21 (2010-09-15)
* Stephen Warren wrote:
> On 03/14/2012 09:56 AM, Thierry Reding wrote:
> > A subsequent patch will add a generic PWM API driver for the Tegra PWFM
> > controller, supporting all four PWM devices with a single PWM chip. The
> > device will be named tegra-pwm and only one clock needs to be provided.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
> ...
> > - CLK_DUPLICATE("pwm", "tegra_pwm.0", NULL),
> > - CLK_DUPLICATE("pwm", "tegra_pwm.1", NULL),
> > - CLK_DUPLICATE("pwm", "tegra_pwm.2", NULL),
> > - CLK_DUPLICATE("pwm", "tegra_pwm.3", NULL),
> > + CLK_DUPLICATE("pwm", "tegra-pwm", NULL),
>
> I thought harder about this: Why not delete /all/ the CLK_DUPLICATE()s
> for PWM, and change the second parameter to PERIPH_CLK for PWM from
> "pwm" to "tegra-pwm"?
I think that should work. I'll retest and will update the patch accordingly.
I assume that you're Acked-by will remain valid after those changes?
Thierry
Attachment:
pgp7Es8_NRp7w.pgp
Description: PGP signature
[ARM Kernel]
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]