[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] tps6586x: Add device-tree support
- Subject: Re: [PATCH 05/11] tps6586x: Add device-tree support
- From: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 8 Mar 2012 15:17:56 +0000
- Cc: linux-tegra@xxxxxxxxxxxxxxx, Liam Girdwood <lrg@xxxxxx>, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Grant Likely <grant.likely@xxxxxxxxxxxx>, Rob Herring <rob.herring@xxxxxxxxxxx>, devicetree-discuss@xxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Colin Cross <ccross@xxxxxxxxxxx>, Olof Johansson <olof@xxxxxxxxx>
- In-reply-to: <20120308151545.GA23934@avionic-0098.mockup.avionic-design.de>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 08, 2012 at 04:15:46PM +0100, Thierry Reding wrote:
> * Mark Brown wrote:
> > ...they all seem to be explicitly named in the device tree so presumably
> > there's enough information in there for the driver to pick any set of
> > regulators in any order. This would be much nicer to use.
> I don't like it much either. The only reason that requirement exists is
> because it makes the assignment of the regulator ID (as defined in the
> include/linux/mfd/tps6586x.h header) very trivial. Would it be better to
> look up the ID based on the node name (sm0 --> TPS6586X_ID_SM_0, ...)?
> Then the only requirement would be that the names match.
Yes, that's going to be more code but much nicer for users.
Description: Digital signature
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Free Online Dating]