Re: [PATCH v3 06/10] pwm: Add NVIDIA Tegra SoC support

[Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>]

* Ryan Mallon wrote:
> On 23/02/12 19:14, Thierry Reding wrote:
> > * Ryan Mallon wrote:
[...]
> >> pwmchip_add should probably verify that the initialisation of the
> >> pwm_chip structure is sane to avoid problems like this.
> > 
> > Absolutely. What would be the best response to an invalid struct pwm_chip? I
> > suppose at least returning -EINVAL, perhaps complemented with WARN_ON?
> 
> Just returning -EINVAL should be okay. I don't think you need a WARN_ON,
> since failing to register the hardware should be enough of a reason for
> a user to report a problem.

Okay, will do.

Thierry

Attachment: pgpvhvKTyPbi6.pgp
Description: PGP signature