Re: [PATCH 1/3] tgtadm: expose blocksize option

[FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>]

On Thu, 29 Sep 2011 08:03:13 +0900
FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:

> On Wed, 28 Sep 2011 13:23:07 -0700
> Andy Grover <agrover@xxxxxxxxxx> wrote:
> 
> > On 09/27/2011 04:56 PM, FUJITA Tomonori wrote:
> > > On Tue, 27 Sep 2011 12:21:30 -0700
> > > Andy Grover <agrover@xxxxxxxxxx> wrote:
> > > 
> > >> From: Federico Simoncelli <fsimonce@xxxxxxxxxx>
> > >>
> > >> This patch adds the new option --blocksize (or -y) to expose a custom block
> > >> size for the LUN.
> > >>
> > >> Signed-off-by: Federico Simoncelli <fsimonce@xxxxxxxxxx>
> > >> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> > >> ---
> > >>  scripts/tgt-admin |    8 +++++++-
> > >>  usr/tgtadm.c      |   16 ++++++++++++----
> > >>  2 files changed, 19 insertions(+), 5 deletions(-)
> > > 
> > > Nice, but can you please update the manpage too?
> > 
> > Will do.
> > 
> > So, the manpages and htmlpages are generated from the xml? While I'm at
> 
> I think so.
> 
> 
> > it, would you like me to generate a patch to remove the generated files
> > from source control?
> 
> I can't recall why we keep these files. Ronnie?

Not everybody installs a tool to generate these files from xml files
so keeping them is handy for some, right?

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html