Re: [PATCH] Specify controller tid in targets.conf

[FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>]

On Wed, 22 Jun 2011 08:14:57 +0200 (CEST)
**UNKNOWN CHARSET** <fredrik.aslund@xxxxxxxxxx> wrote:

> On Tue, 21 Jun 2011, FUJITA Tomonori wrote:
> 
> > > Add controller_tid option to targets.conf to allow admins to configure 
> > > SCSI ID and SCSI SN for controller (lun 0), making them unique across tgt 
> > > servers.
> > 
> > Seems that this patch can't be applied to the latest git tree. Can you
> > send the updated patch?
> > 
> targets.conf.example got patched here:
> --
> commit 147f1471bf9708f20d22b8bb1fa564e98eb97d2e
> Author: Hisashi Osanai <osanai.hisashi@xxxxxxxxxxxxxx>
> Date:   Tue Jun 21 08:33:59 2011 +0900
> 
>     iscsi: add authentication function using initiator's name
> 
>     Signed-off-by: Hisashi Osanai <osanai.hisashi@xxxxxxxxxxxxxx>
>     Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>

Duh :( Sorry about that.

> The patch to tgt-admin remains:
> --
> diff -uprN tgt-1.0.17.orig/scripts/tgt-admin tgt-1.0.17/scripts/tgt-admin
> --- tgt-1.0.17.orig/scripts/tgt-admin	2011-05-30 02:54:07.000000000 +0200
> +++ tgt-1.0.17/scripts/tgt-admin	2011-06-21 08:45:31.000000000 +0200
> @@ -284,6 +284,10 @@ sub add_targets {
>  						$data_key = make_key($target_options_ref, "lun", "allow-in-use");
>  					}
>  
> +					if (defined $target_options{"controller_tid"}) {
> +						$next_tid = $target_options{"controller_tid"};
> +					}
> + 
>  					if (not defined $target_options{"driver"}) {
>  						$target_options{"driver"} = $default_driver;
>  					}
> 
> It should apply to the latest git tree.

Thanks, I've merged. Please check if the latest git code works for
you.

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html