Re: [PATCH 1/2] iscsi user-initiated disconnect fix: release of the current tx task

[FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>]

On Sun, 07 Nov 2010 19:00:19 +0200
Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote:

> Fixes a bug with user-initiated disconnect that led to failures in
> deleting the logical unit and target, during concurrent I/O.
> 
> Typically, the error messages were:
> > tgtadm: this logical unit is still active
> > tgtadm: this target is still active
> (as discussed in the thread "back to forced deletion" starting with 
> http://lists.wpkg.org/pipermail/stgt/2010-September/004095.html)
> 
> The current tx task (conn->tx_task) was freed using the basic function
> iscsi_free_task(), while all other pending tx tasks are freed differentially,
> according to their type. 
> 
> The current tx task also should be freed differentially, or else the task 
> hash table of the nexus remains non-empty and the target is declared active.
> 
> To achieve this the current tx task is added to the list of pending tx tasks
> just before their release, so that it is freed according to the same policy.
> 
> ---
>  usr/iscsi/conn.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

Thanks a lot!

Can you resend this with your Signed-off-by? And please check out your
patch with scripts/checkpatch.pl. The patch includes a trailing space.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html