Re: [PATCH RFC 3/3] - new iser code (after pthreads revert)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, 30 Jul 2010 16:05:11 +0300
Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote:

> > > I propose starting with the "rectification" of iscsi text functions, by
> > > changing them to accept plain char * buffers, making them independent from
> > > iscsi structures specifics. Such semantic changes do not alter the logic
> > > of the existing code... 
> >
> > Please send all the patches that you have now (no need to clean up
> > them). I just want to see the whole picture first.
> 
> Please, view the "wrong" portions outside of iser.* as the "noise" that 
> i did not clean up, and just disregard them. 

I need to review the code more closely however the latest patch
doesn't look bad to me.

At this point, I concluded that I prefer to duplicate the code rather
than unification.

The worst scenario for me is that I don't know what parts of iSCSI
code I can modify safely, i.e., without breaking iser code. It means
that I can't modify iSCSI/tcp code until I understand iser.

With the duplication, I can just tell you that iSCSI/tcp has a bug so
iser might have the similar one. When I understand the iser code, I
could work on the unification.

>From that perspective, the latest patch looks better than the
previous. What parts of iscsid.c iser needs is clearer a bit. If you
can do something for that direction on your patches, please let me
know.

However, as I said before, before I merge your iser work, I really
like to get other iser experts' opinion on the new state machine code.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [XFree86]     [Video Devices]

Add to Google Powered by Linux